Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing v0.13.0a1 pre-release #4840

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

felipesanches
Copy link
Collaborator

@felipesanches felipesanches commented Sep 19, 2024

  • Profile owners, please take a look at the pending_review lists in your profile definitions. If you move them to exclude_checks it means you do not want the check in your profile. If you just remove from pending_review, then the check becomes effective in your profile. And if you do nothing, the checks still not reviewed will continue being automatically excluded from your profile.
  • This release adopts a new naming scheme for checks. We had reports of users getting confused by the meaning of the reverse domain names included as prefixes of check-IDs, such as com.google.fonts. The real meaning was that the organization identified by such domain was the first contributor of a given check implementation. But some users were confused thinking that it mean the check belong to that organization's vendor-specific profile.
  • Now profiles do not include that reverse domain prefix. And do not also have the "/check/" keywork anymore. As an example, com.google.fonts/check/tabular_kerning (on the Universal profile) is now simply called tabular_kerning
  • Also, there's been a large number of checks migrated among profiles. Mosly towards the Universal one.
  • The checks themselves also moved around in the code-repository, in an attempt to remove any resemblance of profile allocation within the /Lib/fontbakery/checks/ directory, which should be seen as a general pool of check implementations. As much as possible, profile definition should happen inside /Lib/fontbakery/profiles instead.
  • The exception to this are the checks that are surely vendor-specific. All those were placed in sub-directories inside Lib/fontbakery/checks/, such as Lib/fontbakery/checks/vendorspecific/microsoft/.
  • There may be additional migrations and renames of checks, before we make an actual v0.13.0 release. Please open an issue if you have suggestions of better names or better profile allocations.

Noteworthy code-changes

New checks

Added to the Google Fonts profile

Changes to existing checks

On the Universal profile

On the Google Fonts profile

Promotion of previously experimental checks

Made effective on the Universal profile

"Ensure the font's instances are in the correct order."

Made effective on the Universal profile.
Was experimental since March/2024.

(issue fonttools#3334)
@felipesanches felipesanches force-pushed the preparing_v0_13_0a1 branch 4 times, most recently from d21e361 to 7713e87 Compare September 20, 2024 00:48
@felipesanches felipesanches merged commit d893d2c into fonttools:main Sep 20, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant