check/caps_vertically_centered (on the universal profile) #4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipesanches
force-pushed
the
caps-centered
branch
from
3644c99
to
8a994a8
Compare
"If possible, the uppercase glyphs should be vertically centered in the em box." 'caps_vertically_centered' On the Universal Profile. (issues fonttools#4139 and fonttools#4274)
felipesanches
force-pushed
the
caps-centered
branch
from
8a994a8
to
b93f2ca
Compare
|
Thanks, @emmamarichal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to issue #4274
@felipesanches I implemented your suggestions, but I still had the false positive. I updated the code, let me know what you think. I'm totally new in the fontbakery, please let me know if I did any mistakes regarding the process.
I tested it on several fonts, this version detects well when the v-metrics are not centered, and the Rosa case isn't detected anymore.
Checklist
CHANGELOG.md