Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate opentype/dsig #4873

Merged
merged 1 commit into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ Below are the noteworthy changes from each release.
A more detailed list of changes is available in the corresponding milestones for each release in the Github issue tracker (https://github.com/googlefonts/fontbakery/milestones?state=closed).

## Upcoming release: 0.13.0 (a4?) (2024-Nov-??)
- ...
### Deprecated checks
#### Removed from the OpenType profile
- **DEPRECATED - [opentype/dsig]:** Merged into **[unwanted_tables]** on the `Universal` profile. (issue #4865)


## 0.13.0a3 (2024-Oct-25)
Expand Down
38 changes: 0 additions & 38 deletions Lib/fontbakery/checks/opentype/dsig.py

This file was deleted.

6 changes: 6 additions & 0 deletions Lib/fontbakery/checks/tables.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,12 @@ def check_required_tables(ttFont, config, is_variable_font):
def check_unwanted_tables(ttFont):
"""Are there unwanted tables?"""
UNWANTED_TABLES = {
"DSIG": (
"This font has a digital signature (DSIG table) which is only required"
" - even if only a placeholder - on old programs like MS Office 2013"
" in order to work properly.\n"
"The current recommendation is to completely remove the DSIG table."
),
"FFTM": "Table contains redundant FontForge timestamp info",
"TTFA": "Redundant TTFAutohint table",
"TSI0": "Table contains data only used in VTT",
Expand Down
1 change: 0 additions & 1 deletion Lib/fontbakery/profiles/adobefonts.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"notofonts/unicode_range_bits", # so maybe there's still some change they may be considered useful here?
#
"opentype/caret_slope",
"opentype/dsig",
"opentype/fsselection",
"opentype/gdef_mark_chars",
"opentype/gdef_non_mark_chars",
Expand Down
1 change: 0 additions & 1 deletion Lib/fontbakery/profiles/opentype.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"opentype/cff_call_depth",
"opentype/cff_deprecated_operators",
"opentype/code_pages",
"opentype/dsig",
"opentype/family/bold_italic_unique_for_nameid1",
"opentype/family/consistent_family_name",
"opentype/family/equal_font_versions",
Expand Down
6 changes: 0 additions & 6 deletions docs/source/fontbakery/checks/opentype.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ CFF table checks
.. automodule:: fontbakery.checks.opentype.cff
:members:

DSIG table checks
*****************

.. automodule:: fontbakery.checks.opentype.dsig
:members:

fvar table checks
*****************

Expand Down
24 changes: 0 additions & 24 deletions tests/test_checks_opentype_dsig.py

This file was deleted.

1 change: 1 addition & 0 deletions tests/test_checks_universal.py
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,7 @@ def test_check_unwanted_tables():
check = CheckTester("unwanted_tables")

unwanted_tables = [
"DSIG",
"FFTM", # FontForge
"TTFA", # TTFAutohint
"TSI0", # TSI* = VTT
Expand Down
Loading