Skip to content

Commit

Permalink
make lxml optional
Browse files Browse the repository at this point in the history
requiring lxml is too heavy-handed, given that fonttools itself doesn't require
and neither does defcon (which is similar to ufoLib2).
There still isn't a pre-compiled wheel for lxml for Python 3.8 on PyPI.
Better to keep it optional, i.e. 'pip install ufoLib2[lxml]'.
  • Loading branch information
anthrotype committed Oct 18, 2019
1 parent f2aa9d0 commit 9ab4c35
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@
packages=find_packages("src"),
include_package_data=True,
python_requires=">=3.6",
install_requires=["fonttools[ufo,lxml] >= 3.34.0", "attrs >= 18.2.0"],
install_requires=["fonttools[ufo] >= 3.34.0", "attrs >= 18.2.0"],
setup_requires=["setuptools_scm"],
extras_require={"lxml": ["lxml"]},
classifiers=[
"Development Status :: 4 - Beta",
"Operating System :: OS Independent",
Expand Down

0 comments on commit 9ab4c35

Please sign in to comment.