support defcon-like Font(path) default constructor #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they should not be taken into account when comparing two layers (or data or images sets).
So that one can do Font(path) like in defcon #41
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 69.69% 71.82% +2.13%
==========================================
Files 19 19
Lines 1023 1072 +49
Branches 145 159 +14
==========================================
+ Hits 713 770 +57
+ Misses 265 258 -7
+ Partials 45 44 -1
Continue to review full report at Codecov.
|
anthrotype
force-pushed
the
defcon-path-constructor
branch
from
d55c272
to
f6ea611
Compare
anthrotype
force-pushed
the
defcon-path-constructor
branch
from
585a704
to
03bf9ee
Compare
anthrotype
force-pushed
the
defcon-path-constructor
branch
from
03bf9ee
to
15d6f0f
Compare
madig
approved these changes
Dec 16, 2019
madig
reviewed
Dec 16, 2019
otherwise one may inadvertently lose reference to the reader object and leave it open as result of comparing for equality or deepcopying (which automatically call unlazify). For all the lazy objects (Font, LayerSet, Layer, Data and Images) I implement a custom __deepcopy__ method that ignores init=False attributes while copying (such as the reader).
'path' must be init=True, but we don't want to pass it to the default constructor when we deepcopy otherwise we end up reading from disk again while deepcopying...
madig
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41 to ease up projects wishing to support both defcon and ufoLib2