Improve financial link feature & transaction links #1064
Conversation
twothreenine
force-pushed
the
feature/improve-financial-link-feature-redone
branch
3 times, most recently
from
af7f4b8
to
11592a0
Compare
| view_context.link_to ft.note, new_finance_order_path(order_id: ft.group_order.order.id) | ||
| else | ||
| ft.note | ||
| end |
There was a problem hiding this comment.
I tried to replace L16:L21 with
ft_note = render "finance/financial_transactions/order_note", financial_transaction:ft, with_grouporder_link: false
but this gave me the following error:
Missing template finance/financial_transactions/order_note with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :haml]}. Searched in: * "/app/app/views" * "/app/plugins/wiki/app/views" * "/app/plugins/polls/app/views" * "/app/plugins/messages/app/views" * "/app/plugins/links/app/views" * "/app/plugins/documents/app/views" * "/usr/local/bundle/ruby/2.7.0/gems/twitter-bootstrap-rails-2.2.8/app/views" * "/usr/local/bundle/ruby/2.7.0/gems/kaminari-core-1.2.2/app/views" * "/usr/local/bundle/ruby/2.7.0/gems/doorkeeper-5.6.8/app/views" * "/usr/local/bundle/ruby/2.7.0/gems/actiontext-7.0.8/app/views" * "/usr/local/bundle/ruby/2.7.0/gems/actionmailbox-7.0.8/app/views" Did you mean? finance/financial_transactions/index_collection finance/financial_transactions/new_collection finance/financial_transactions/index finance/balancing/edit_note finance/financial_transactions/new finance/financial_links/incomplete
|
A good addition would be #1067 (adding multiple transactions to a finance link at once), but it's beyond my rails skills. |
twothreenine
force-pushed
the
feature/improve-financial-link-feature-redone
branch
3 times, most recently
from
ea5adba
to
c9e4442
Compare
- add a config option "use_financial_links" for activating both finance links and foodcoop transaction features - add migration: set this option to true if any financial link or foodcoop transaction exists - add options to create a financial link and/or foodcoop transaction when balancing an order - show links to finance links only to users with finance role (required anyway, but links were shown in home/ordergroup) - add note column when adding a financial transaction to a link - financial transactions: show link to group_order only in home/ordergroup and (additionally) dashboard; replace with link to order's balancing page in finance views - finance link: show link in financial transaction note to respective order's balancing page (also when adding a financial transaction) - finance link: replace misleading "delete" button for removing a transaction with "remove from link", also adapt confirm message - adapt en/de locales, fix finance-related locale typos
twothreenine
force-pushed
the
feature/improve-financial-link-feature-redone
branch
from
c9e4442
to
ce7f146
Compare
|
@yksflip I finished what we discussed today. |
home/ordergroupand (additionally) dashboard; replace with link to order's balancing page in finance viewsNotes:
ordereither. I thought about adding the relation, but I think it's unnecessary to add a column in the db just for foodcoop transactions, as you can go to the order with one additional click (by opening the financial link and clicking on a non-foodcoop transaction).finance/financial_transactions/_order_note, but I couldn't call it from financial_links_controller. See comment for details.Implementation of #848
Replaces #860