Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: List attributes to allow to search for SharedArticles #1071

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

kidhab
Copy link
Contributor

@kidhab kidhab commented Aug 21, 2024

Without this list the application throws an error message if one tries to search for articles to be imported from a shared suppliers.

From the error message:
Ransack needs SharedArticle attributes explicitly allowlisted as searchable

@yksflip
Copy link
Member

yksflip commented Aug 28, 2024

hey thanks for your pr!
can you resolve the rubocop issues or should i help out?

@kidhab
Copy link
Contributor Author

kidhab commented Sep 3, 2024

I will have a look at the issue this week.

@kidhab kidhab force-pushed the SharedArticleFix branch 2 times, most recently from d3c3113 to eea93f2 Compare September 3, 2024 18:47
Without this list the application throws an error message if one tries to search for articles to import from a shared suppliers.

From the error message:
`Ransack needs SharedArticle attributes explicitly allowlisted as searchable`
@kidhab
Copy link
Contributor Author

kidhab commented Sep 3, 2024

done.

@yksflip yksflip merged commit 69de2a8 into foodcoops:master Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants