Private/bryan/no wdfiotarget retries #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forderud
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Comments:
- This PR contains a mix of unrelated changes that should not be bundled. This makes it difficult to review and risky to merge. Therefore, please split the changes into at least two separate PR's. One PR for the
IoRegisterPlugPlayNotificationchanges and one PR fordevconremoval. - Please rebase your changes on top of the "main" branch, so that you avoid merge commits in your PR.
- If you want to introduce tracing or change
KdPrintusage, then please submit that in a separate PR. Such changes does not belong in this PR.
|
I've now cleaned up and resubmitted your "devcon removal" commit as #53, so you don't need to think more about that part. Driver loading with just pnputil worked like a charm after installing the driver certificate, so I've already merged the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WdfIoTargetOpen Reliability Experiments & Preferred driver installation.
A thunk to pageable code is needed from IoRegisterPnPNotification in all options as WdfIoTargetOpen is pageable. The callback for RegisterPnPNotification runs at DPC.
Basic overview of code flow
The SelfManagedIoinit handler registers a PnP notification handler.
The PnP notification handler acts upon the arrival of the IntelliMouse's interface No. 5.
This is option No. 3 of 3 options.
Just call WdfIoTargetOpen from a workitem. The timer creates a workitem that then calls WdfIoTargetOpen.
The workitem then calls WdfIoTargetOpen.
Tested on one machine. There have been no failures of WdfIoTargetOpen.
This PR fixes issue #44.
Installcert.bat needs to be run before Install_Taillight.bat.