Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions: use maintained rust toolchain setup action for linter #883

Merged
merged 3 commits into from
Sep 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,30 +7,23 @@ on:
- main
- staging # for Bors
- trying # for Bors
merge_group:
jobs:
linter:
name: linter
runs-on: ubuntu-latest
continue-on-error: true
steps:
- name: checkout_repo
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: install_rust
uses: actions-rs/toolchain@v1
uses: dtolnay/rust-toolchain@stable
with:
toolchain: stable
override: true
profile: minimal
components: clippy

- name: check_with_clippy_backend_pixels
uses: actions-rs/clippy-check@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
args: --all-targets --no-default-features --features backend_pixels -- -D warnings
run: cargo clippy --all-targets --no-default-features --features backend_pixels -- -D warnings

- name: check_with_clippy_backend_piston_window
uses: actions-rs/clippy-check@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
args: --all-targets --no-default-features --features backend_piston_window -- -D warnings
run: cargo clippy --all-targets --no-default-features --features backend_piston_window -- -D warnings
12 changes: 1 addition & 11 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,13 @@ jobs:
strategy:
fail-fast: false
matrix:
build: [stable, beta, nightly, win-gnu, win-msvc]
build: [stable, win-gnu, win-msvc]
include:
# latest rust stable :: ubuntu
- build: stable
os: ubuntu-latest
rust: stable

# latest rust beta :: ubuntu
- build: beta
os: ubuntu-latest
rust: beta

# latest rust nightly :: ubuntu
- build: nightly
os: ubuntu-latest
rust: nightly

# latest rust stable :: windows + gnu
- build: win-gnu
os: windows-latest
Expand Down
2 changes: 2 additions & 0 deletions tests/cli.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(clippy::items_after_test_module)]

use assert_cmd::Command;
use common::input;
use parameterized::{ide, parameterized};
Expand Down
Loading