Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump the winit group with 2 updates #928

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 17, 2023

Bumps the winit group with 2 updates: winit and winit_input_helper.

Updates winit from 0.27.5 to 0.28.6

Release notes

Sourced from winit's releases.

Winit Version v0.28.6

  • On macOS, fixed memory leak when getting monitor handle.
  • On macOS, fix Backspace being emitted when clearing preedit with it.

Winit Version v0.28.5

  • On macOS, fix key_up being ignored when Ime is disabled.

Winit Version v0.28.4 [yanked]

  • On macOS, fix empty marked text blocking regular input.
  • On macOS, fix potential panic when getting refresh rate.
  • On macOS, fix crash when calling Window::set_ime_position from another thread.

Winit Version v0.28.3

  • Fix macOS memory leaks.

Winit Version v0.28.2

  • Implement HasRawDisplayHandle for EventLoop.
  • On macOS, set resize increments only for live resizes.
  • On Wayland, fix rare crash on DPI change.
  • On Web, add support for Window::theme.
  • On Wayland, fix rounding issues when doing resize.
  • On macOS, fix wrong focused state on startup.
  • On Windows, fix crash on setting taskbar when using Visual Studio debugger.
  • On macOS, resize simple fullscreen windows on windowDidChangeScreen events.

Winit Version v0.28.1

  • On Wayland, fix crash when dropping a window in multi-window setup.

Winit Version v0.28.0

  • On macOS, fixed Ime::Commit persisting for all input after interacting with Ime.
  • On macOS, added WindowExtMacOS::option_as_alt and WindowExtMacOS::set_option_as_alt.
  • On Windows, fix window size for maximized, undecorated windows.
  • On Windows and macOS, add WindowBuilder::with_active.
  • Add Window::is_minimized.
  • On X11, fix errors handled during register_xlib_error_hook invocation bleeding into winit.
  • Add Window::has_focus.
  • On Windows, fix Window::set_minimized(false) not working for windows minimized by Win + D hotkey.
  • Breaking: On Web, touch input no longer fires WindowEvent::Cursor*, WindowEvent::MouseInput, or DeviceEvent::MouseMotion like other platforms, but instead it fires WindowEvent::Touch.
  • Breaking: Removed platform specific WindowBuilder::with_parent API in favor of WindowBuilder::with_parent_window.
  • On Windows, retain WS_MAXIMIZE window style when un-minimizing a maximized window.
  • On Windows, fix left mouse button release event not being sent after Window::drag_window.
  • On macOS, run most actions on the main thread, which is strictly more correct, but might make multithreaded applications block slightly more.
  • On macOS, fix panic when getting current monitor without any monitor attached.
  • On Windows and MacOS, add API to enable/disable window buttons (close, minimize, ...etc).
  • On Windows, macOS, X11 and Wayland, add Window::set_theme.
  • Breaking: Remove WindowExtWayland::wayland_set_csd_theme and WindowBuilderExtX11::with_gtk_theme_variant.
  • On Windows, revert window background to an empty brush to avoid white flashes when changing scaling.
  • Breaking: Removed Window::set_always_on_top and related APIs in favor of Window::set_window_level.
  • On Windows, MacOS and X11, add always on bottom APIs.
  • On Windows, fix the value in MouseButton::Other.

... (truncated)

Changelog

Sourced from winit's changelog.

0.28.6

  • On macOS, fixed memory leak when getting monitor handle.
  • On macOS, fix Backspace being emitted when clearing preedit with it.

0.28.5

  • On macOS, fix key_up being ignored when Ime is disabled.

0.28.4

  • On macOS, fix empty marked text blocking regular input.
  • On macOS, fix potential panic when getting refresh rate.
  • On macOS, fix crash when calling Window::set_ime_position from another thread.

0.28.3

  • Fix macOS memory leaks.

0.28.2

  • Implement HasRawDisplayHandle for EventLoop.
  • On macOS, set resize increments only for live resizes.
  • On Wayland, fix rare crash on DPI change
  • Web: Added support for Window::theme.
  • On Wayland, fix rounding issues when doing resize.
  • On macOS, fix wrong focused state on startup.
  • On Windows, fix crash on setting taskbar when using Visual Studio debugger.
  • On macOS, resize simple fullscreen windows on windowDidChangeScreen events.

0.28.1

  • On Wayland, fix crash when dropping a window in multi-window setup.

0.28.0

  • On macOS, fixed Ime::Commit persisting for all input after interacting with Ime.
  • On macOS, added WindowExtMacOS::option_as_alt and WindowExtMacOS::set_option_as_alt.
  • On Windows, fix window size for maximized, undecorated windows.
  • On Windows and macOS, add WindowBuilder::with_active.
  • Add Window::is_minimized.
  • On X11, fix errors handled during register_xlib_error_hook invocation bleeding into winit.
  • Add Window::has_focus.
  • On Windows, fix Window::set_minimized(false) not working for windows minimized by Win + D hotkey.
  • Breaking: On Web, touch input no longer fires WindowEvent::Cursor*, WindowEvent::MouseInput, or DeviceEvent::MouseMotion like other platforms, but instead it fires WindowEvent::Touch.
  • Breaking: Removed platform specific WindowBuilder::with_parent API in favor of WindowBuilder::with_parent_window.
  • On Windows, retain WS_MAXIMIZE window style when un-minimizing a maximized window.
  • On Windows, fix left mouse button release event not being sent after Window::drag_window.
  • On macOS, run most actions on the main thread, which is strictly more correct, but might make multithreaded applications block slightly more.
  • On macOS, fix panic when getting current monitor without any monitor attached.

... (truncated)

Commits
  • 640c51f Winit version 0.28.6
  • 8e4ef92 On macOS, fix backspace emission on preedit clear
  • 5278441 Fix device description leak (#2758)
  • 340202f Winit version 0.28.5
  • 870e6d1 On macOS, fix key_up being ignored without IME
  • b455f88 Winit version 0.28.4
  • 30678cb On Wayland, fix nightly warnings
  • bb26b03 On macOS, fix empty marked text blocking input
  • 6f97ff1 On X11, fix nightly warnings
  • 0881a28 Run Window::set_ime_position on main thread on macOS
  • Additional commits viewable in compare view

Updates winit_input_helper from 0.13.0 to 0.15.1

Changelog

Sourced from winit_input_helper's changelog.

Changelog

This changelog is written with the goal of helping you through breaking changes rather than being a complete documentation of every change in the release.

0.15

Upgraded to winit 0.29. Winit 0.29 completely overhauled its keyboard API, which meant that I had to also overhaul our keyboard API.

Previously winit_input_helper favored logical keys over physical keys (previously called scancodes). But this was a mistake, driven by winit's poor support for physical keys and mistaken simplification of logical keys. Winit has now fixed these mistakes and as a result winit_input_helper is now swapping to favor physical keys.

A direct translation of the previous API to the new API:

// old
input.key_pressed_scancode(17); // US scan code for W
// new
input.key_presed(winit::keyboard::KeyCode::KeyW);
// old
input.key_pressed(winit::event::VirtualKeyCode::KeyW);
// new
input.key_presed_logical(winit::keyboard::Key::Character("w")); // WARNING: this likely wont actually do what you want, this will never return true while shift is held since that is considered as W instead of w
// ... other keyboard methods follow the same pattern

However, I actually suggest you move to physical keys:

// old
input.key_pressed_scancode(17); // US scan code for W
// new
input.key_presed(winit::keyboard::KeyCode::KeyW);
// old
input.key_pressed(winit::event::VirtualKeyCode::W);
// new
input.key_presed(winit::keyboard::KeyCode::KeyW);

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from foresterre November 17, 2023 10:22
@dependabot dependabot bot force-pushed the dependabot/cargo/winit-d2feb92602 branch from 73177a4 to ba88a48 Compare December 6, 2023 10:33
@dependabot dependabot bot force-pushed the dependabot/cargo/winit-d2feb92602 branch 7 times, most recently from 232c293 to b0dff2f Compare December 22, 2023 10:36
@dependabot dependabot bot force-pushed the dependabot/cargo/winit-d2feb92602 branch 4 times, most recently from b40654b to e3587c3 Compare December 28, 2023 10:41
@dependabot dependabot bot force-pushed the dependabot/cargo/winit-d2feb92602 branch 3 times, most recently from c132af3 to cac0578 Compare January 5, 2024 10:58
@dependabot dependabot bot force-pushed the dependabot/cargo/winit-d2feb92602 branch from cac0578 to ed2ad3e Compare January 11, 2024 10:53
Bumps the winit group with 2 updates: [winit](https://github.com/rust-windowing/winit) and [winit_input_helper](https://github.com/rukai/winit_input_helper).


Updates `winit` from 0.27.5 to 0.28.6
- [Release notes](https://github.com/rust-windowing/winit/releases)
- [Changelog](https://github.com/rust-windowing/winit/blob/master/CHANGELOG.md)
- [Commits](rust-windowing/winit@v0.27.5...v0.28.6)

Updates `winit_input_helper` from 0.13.0 to 0.15.1
- [Changelog](https://github.com/rukai/winit_input_helper/blob/main/changelog.md)
- [Commits](https://github.com/rukai/winit_input_helper/commits)

---
updated-dependencies:
- dependency-name: winit
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: winit
- dependency-name: winit_input_helper
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: winit
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/winit-d2feb92602 branch from ed2ad3e to e0f3520 Compare January 12, 2024 10:44
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 15, 2024

Superseded by #993.

@dependabot dependabot bot closed this Jan 15, 2024
@dependabot dependabot bot deleted the dependabot/cargo/winit-d2feb92602 branch January 15, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants