Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial stable version #5

Merged
merged 7 commits into from
Feb 10, 2024
Merged

initial stable version #5

merged 7 commits into from
Feb 10, 2024

Conversation

travi
Copy link
Member

@travi travi commented Feb 8, 2024

complete scaffolding of a minimal pom

  • modelVersion
  • artifactId
  • groupId
  • version

@travi travi marked this pull request as draft February 8, 2024 21:55
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@form8ion/core@4.2.0 filesystem Transitive: environment +14 10.6 MB form8ion-bot
npm/fast-xml-parser@4.3.4 None +1 130 kB amitgupta

View full report↗︎

Copy link

codecov bot commented Feb 8, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@travi
Copy link
Member Author

travi commented Feb 8, 2024

  • for groupId, what is the best name to refer to this? "namespace"?
  • for version, what is a common initial version?
    • 1.0.0?
    • 0.0.1?
    • would we want to figure out how to make this be managed by semantic-release, or is that overreaching with opinions that should be introduced as options later?

https://maven.apache.org/guides/mini/guide-naming-conventions.html

@travi
Copy link
Member Author

travi commented Feb 10, 2024

opened #10 for remaining scaffolding for the minimal pom. going to merge the current progress to stable and iterate from there

@travi travi marked this pull request as ready for review February 10, 2024 05:23
@travi travi merged commit ae853b9 into master Feb 10, 2024
7 checks passed
@travi travi deleted the alpha branch February 10, 2024 05:23
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released This issue or pull-request was included in a version released by semantic-release label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue or pull-request was included in a version released by semantic-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant