WIP: Remove turbo_frames now morphing handles it automatically

forsbergplustwo · Dec 1, 2023 · 75daebf · 75daebf
1 parent b4e6d16
commit 75daebf
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/app/views/metrics/_filter.html.erb b/app/views/metrics/_filter.html.erb
@@ -1,7 +1,7 @@
   <%= form_tag(
     url_for(action: action_name, charge_type: filter.charge_type),
     method: :get,
-    data: {controller: "filters", turbo_frame: :metrics, turbo_action: :advance},
+    data: {controller: "filters"},
   ) do %>
 
     <%= hidden_field_tag :chart, filter.chart %>

diff --git a/app/views/metrics/_forecasts_form.html.erb b/app/views/metrics/_forecasts_form.html.erb
@@ -5,9 +5,7 @@
     data: {
       controller: "submittable",
       submittable_target: "form",
-      action: "change->submittable#submit",
-      turbo_frame: :metrics,
-      turbo_action: :advance
+      action: "change->submittable#submit"
     }
   ) do |form| %>
 

diff --git a/app/views/metrics/_tile.html.erb b/app/views/metrics/_tile.html.erb
@@ -5,10 +5,6 @@
       content: polaris_icon(name: "ViewMinor", color: :subdued),
       title: "View chart",
       url: url_for(action: action_name, **filter.to_param.merge(chart: tile.handle)),
-      data: {
-        turbo_frame: "metrics",
-        turbo_action: "advance",
-      },
     }]
   ) do %>
       <%= polaris_stack(alignment: :center) do |stack| %>

diff --git a/app/views/metrics/show.html.erb b/app/views/metrics/show.html.erb
@@ -5,7 +5,7 @@
 
   <%= render "shared/page_actions", page: page %>
 
-  <%= turbo_frame_tag :metrics, data: { controller: "loading" } do %>
+  <%= tag.div data: { controller: "loading" } do %>
 
     <%= polaris_vertical_stack(gap: "6") do %>