Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use S3_BUCKET if set for processing payment CSV #72

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

d-beck
Copy link
Contributor

@d-beck d-beck commented Sep 14, 2023

Just sharing a small change I needed to make to get this to work locally. The code to download the payment history CSV from S3 still appeared to use the hard-coded partner-metrics bucket.

I've set the fallback to partner-metrics if the environmental variable isn't set but not sure if that's necessary

Copy link
Owner

@forsbergplustwo forsbergplustwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for pointing this out @d-beck ! 😊

@forsbergplustwo forsbergplustwo merged commit 6536b34 into forsbergplustwo:main Sep 14, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants