New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Turbo 8 morphing frames #92

Closed

forsbergplustwo wants to merge 2 commits into turbo-8-morphing from turbo-8-morphing-frames

Owner

forsbergplustwo commented Dec 1, 2023 •

edited

Loading

Prototype where we remvoe turbo_frames and rely on morphing instead.

Remove metrics frame
Check if filters work exactly the same and preserve scroll
Normal navigation (to another page) now does not scroll to top, so need to check how to tell it when to preserve scroll or not
Get Chartkick reacting to events again (not turbo's fault)

EDIT: I think it's actually not morphing but instead replacing body like normal navigation 😅

forsbergplustwo added 2 commits

December 1, 2023 14:18


          WIP: Remove turbo_frames now morphing handles it automatically

75daebf


          Keep turbo frame, but dont tell it which one to update

Owner Author

forsbergplustwo commented Dec 1, 2023

Closing until more documentation.. not quite sure about the correct way here.

forsbergplustwo closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet