-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweep: Pagination Missing on "Shop Summary" Merchant Table (β Sandbox Passed) #99
Conversation
Rollback Files For Sweep
|
|
π Wrote ChangesDone. This is an automated message generated by Sweep AI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, see comment and make sure all changed lines of code use double-quoted strings π
Remove the pagination helper file, itβs no longer needed. Update pr to use double-quoted strings only. |
Great, fix any bugs related to first and last page of results (donβt include the url to the pagination view helper). |
π Wrote ChangesDone. This is an automated message generated by Sweep AI. |
Add a controller test for this, and make sure pagination works. You may need to set per_page to 1 in the test temporarily, so it works. |
π Wrote ChangesDone. This is an automated message generated by Sweep AI. |
end | ||
|
||
test "index pagination" do | ||
get :index, params: { selected_app: @selected_app.id, page: 1 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[standard] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog πΆ
Space inside { detected.
get :index, params: { selected_app: @selected_app.id, page: 1 } | |
get :index, params: {selected_app: @selected_app.id, page: 1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end | ||
|
||
test "index pagination" do | ||
get :index, params: { selected_app: @selected_app.id, page: 1 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[standard] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog πΆ
Space inside } detected.
get :index, params: { selected_app: @selected_app.id, page: 1 } | |
get :index, params: { selected_app: @selected_app.id, page: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end | ||
|
||
test "index pagination" do | ||
get :index, params: { selected_app: @selected_app.id, page: 1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[standard] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog πΆ
Space inside { detected.
get :index, params: { selected_app: @selected_app.id, page: 1} | |
get :index, params: {selected_app: @selected_app.id, page: 1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end | ||
|
||
test "index pagination" do | ||
get :index, params: {selected_app: @selected_app.id, page: 1 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[standard] <Layout/SpaceInsideHashLiteralBraces> reported by reviewdog πΆ
Space inside } detected.
get :index, params: {selected_app: @selected_app.id, page: 1 } | |
get :index, params: {selected_app: @selected_app.id, page: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Wrote Changes
I wasn't able to make changes. This could be due to an unclear request or a bug in my code.
As a reminder, comments on a file only modify that file. Comments on a PR (at the bottom of the "conversation" tab) can modify the entire PR. Please try again or contact us on Discord
This is an automated message generated by Sweep AI.
PR Feedback: π
Description
This pull request adds pagination functionality to the "Shop Summary" page in the application. It includes changes to the
Summarys::ShopController
,app/helpers/pagination_helper.rb
,app/models/summary/shop.rb
, andapp/views/summarys/index.html.erb
files.Summary
@page
and@per_page
variables to theindex
action inSummarys::ShopController
summarize
method inSummary::Shop
to acceptpage
andper_page
parametersPaginationHelper
module to thepagination_helper.rb
filesummarized_shop_data
method inSummary::Shop
to include pagination logicindex.html.erb
fileFixes #96.
π Latest improvements to Sweep:
π‘ To get Sweep to edit this pull request, you can: