Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better expose the fftpack interface #47

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Better expose the fftpack interface #47

merged 3 commits into from
Mar 17, 2024

Conversation

rouson
Copy link
Contributor

@rouson rouson commented Mar 11, 2024

This commit

  1. Exposes and clarifies fftpack's public interface (the fftpack module) by isolating it in the src/ subdirectory and moving all other src files to a new fftpack subdirectory.
  2. Adjusts the CMake build system accordingly.

No adjustment to the fpm manifest is necessary. Both build systems still work.

This commit
1. Exposes and clarifies fftpack's public interface by isolating it
   in the src/ subdirectory and moving all other src files to a new
   fftpack subdirectory.
2. Adjusts the CMake build system accordingly.

No adjustment to the fpm manifest is necessary. Both build systems
still work.
Copy link
Contributor

@zoziha zoziha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing, looks good to me!

@zoziha
Copy link
Contributor

zoziha commented Mar 12, 2024

This folder structure change breaks the makefile build, but I think we can easily build the fftpack via cmake, meson, and fpm, and the makefile doesn't seem to be necessary, and we can remove support for it, like fortran-lang/stdlib.

Previously we did not set a CI test for the makefile, and the relevant files included:

  1. makefile in each folder;
  2. the makefile description in the README.

@rouson rouson merged commit f56daca into main Mar 17, 2024
30 checks passed
@rouson rouson deleted the expose-interface branch March 17, 2024 20:31
@rouson rouson mentioned this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants