Add Support for Annex K functions according to C11 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostafa-salmaan
force-pushed
the
mostafas_add_support_for_Annex-k
branch
19 times, most recently
from
04afd0d
to
56540aa
Compare
mostafa-salmaan
force-pushed
the
mostafas_add_support_for_Annex-k
branch
from
9caaf80
to
9114c82
Compare
mostafa-salmaan
force-pushed
the
mostafas_add_support_for_Annex-k
branch
4 times, most recently
from
caadf32
to
a5676de
Compare
These functions make it easier to call the semihosting functions without having to declare a local struct in each caller. Since there is only one call with 4 indirect parameters, I did not add a sys_semihost4 wrapper.
Optimize strcmp by calling orc.b (OR-Combine) instruction when Zbb extension is supported instead of 4 instructions to detect if zero byte is exist in word Signed-off-by: Mohamed Moawad <moawad@synopsys.com>
Enable zbb extension in CI for RISC-V to test optimizations using bit manipulation instructions like `orc.b`. This ensures that the strcmp optimization and other features using zbb are tested and validated Signed-off-by: Mohamed Moawad <moawad@synopsys.com>
mostafa-salmaan
force-pushed
the
mostafas_add_support_for_Annex-k
branch
2 times, most recently
from
0328b5e
to
ed68028
Compare
mostafa-salmaan
force-pushed
the
mostafas_add_support_for_Annex-k
branch
4 times, most recently
from
7a38b64
to
5ccabbb
Compare
…trtod()` Quoting from C standard part 7.19.6.2 > `a,e,f,g` Matches an optionally signed floating-point number, infinity, or NaN, whose format is the same as expected for the subject sequence of the `strtod` function. The corresponding argument shall be a pointer to floating. Regarding `strtod`, quoting from C standard part 7.20.1.3 > A character sequence `NAN` or `NAN(n-char-sequence)`, is interpreted as a quiet NaN, if supported in the return type, else like a subject sequence part that does not have the expected form; the meaning of the `n-char sequences` is implementation-defined. Signed-off-by: Abdallah Abdelhafeez (Abdallahs70)
Make the new code match the old format Signed-off-by: Keith Packard <keithp@keithp.com>
mostafa-salmaan
force-pushed
the
mostafas_add_support_for_Annex-k
branch
3 times, most recently
from
67b9b80
to
514dd2e
Compare
To avoid depending on a .specs file, we can't let meson insert the libraries relative to the link_args by itself as the link_args end up after the libs, which breaks the printf/scanf symbol definitions. Signed-off-by: Keith Packard <keithp@keithp.com>
The generated specs files reference installed versions of the library files. If those are already present in the system, we may end up using them for things like #include_next. The existing compile and link args already provide all of the values which the .specs files want to add. Signed-off-by: Keith Packard <keithp@keithp.com>
I couldn't figure out why it got confused about the bounds checking for pmatches. Signed-off-by: Keith Packard <keithp@keithp.com>
Keep stdio.h from making other standard symbols visible Signed-off-by: Keith Packard <keithp@keithp.com>
Follow POSIX requirements for visible symbols by placing them all in signal.h and then cleaning that up to stop making other symbols visible. Signed-off-by: Keith Packard <keithp@keithp.com>
sys/cdefs already includes this Signed-off-by: Keith Packard <keithp@keithp.com>
move 'error_t' to argz.h and envz.h where it belongs. Get rid of __LINUX_ERRNO_EXTENSIONS__ -- C allows the library to define as many errno values as it likes. Signed-off-by: Keith Packard <keithp@keithp.com>
Move sys/cdefs include to the top of the file. Signed-off-by: Keith Packard <keithp@keithp.com>
sys/config.h is included by sys/cdefs.h, which is included by every public header. Signed-off-by: Keith Packard <keithp@keithp.com>
This will be included by any public header, so the internal source files don't need to also include it. Signed-off-by: Keith Packard <keithp@keithp.com>
Not even newlib still supports any of this mechanism. Remove the collate.c file and eliminate all internal usage of __collate_load_error. Signed-off-by: Keith Packard <keithp@keithp.com>
PATH_MAX is a posix value, not a C value. Signed-off-by: Keith Packard <keithp@keithp.com>
Make sure limits.h doesn't expose any non-C limits unless the application requests them. Signed-off-by: Keith Packard <keithp@keithp.com>
This is a machine-specific file, not an OS specific file. Signed-off-by: Keith Packard <keithp@keithp.com>
This is declared in sys/_timespec.h already, no need to duplicate it here. Signed-off-by: Keith Packard <keithp@keithp.com>
These are required by C. Signed-off-by: Keith Packard <keithp@keithp.com>
_POSIX2_RE_DUP_MAX is the minimum acceptable value for any POSIX system while RE_DUP_MAX is the value supported by the library. Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
force-pushed
the
mostafas_add_support_for_Annex-k
branch
from
514dd2e
to
d306507
Compare
Adding an implementation of the bounds-checking C functions (as specified in Annex K of the C11 standard) to the PicoLibc. These functions lower the risk of introducing security vulnerabilities such as buffer overflows and format string vulnerabilities into your code by providing clear and easy-to-use interfaces. For each C function a secure alternate function ending in a "_s" postfix is provided (e.g., strcpy_s). Use of these functions is recommended by security experts and secure coding standards. also, Implemented unit tests for the Annex-K functions to ensure their corrctness. Covered various scenarios including normal operation, boundary conditions, and error handling. Signed-off-by: Mostafa Salman <mostafas@synopsys.com>
keith-packard
force-pushed
the
mostafas_add_support_for_Annex-k
branch
from
d306507
to
1e23bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an implementation of the bounds-checking C functions (as specified in Annex K of the C11 standard) to the PicoLibc. These functions lower the risk of introducing security vulnerabilities such as buffer overflows and format string vulnerabilities into your code by providing clear and easy-to-use interfaces. For each C function a secure alternate function ending in a "_s" postfix is provided (e.g., strcpy_s). Use of these functions is recommended by security experts and secure coding standards.