Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dunfell patch provided by Baxter #11

Open
wants to merge 1 commit into
base: dunfell
Choose a base branch
from
Open

Conversation

ryanlink
Copy link

@ryanlink ryanlink commented Oct 30, 2024

Overview

This patch provided by Baxter International (Eric Laurin and Zachary Salim). They have not tested the dunfell patch since they are no longer using dunfell in their builds.

Acceptance criteria

If this PR is successful, what impact does it have on the user experience?

Example: When users do X, Y should now happen.

Testing plan

Someone with access to a bitbake repo and dunfell Yocto should test this.

Risks

Could break the meta-fossa integration.

References

The Dunfell patch applies modifications to make meta-fossa compatible with the dunfell Yocto Project branch. Here’s a breakdown of the key changes described:

  1. fossa_upload.bbclass Modifications:
  • Change to do_fossa_analyze and do_fossa_test tasks: The patch changes these tasks to run fossa-cli-native instead of fossa-cli. The fossa-cli-native package is compiled for the build host, while fossa-cli is typically compiled for the target. This ensures that analysis and testing tasks are compatible with the build host environment.
  • Path Removal for the fossa Binary: It removes the hardcoded path to the fossa binary, instead relying on it to be in the system PATH. This improves portability across different build hosts where the fossa binary location may vary.
  1. fossa.bbclass Modifications:
  • Addition of image_list_installed_packages: This patch introduces the image_list_installed_packages function from the OpenEmbedded core (oe-core). This function generates a list of all packages installed in the final image, which is used to retrieve dependencies and populate the pkg_metadata output JSON file with accurate package dependency data.
  1. fossa-cli.bb Modifications:
  • Extension with native Bitbake Class: The patch extends the fossa-cli recipe to build fossa-cli as a native package (for the build host) rather than for the target device. This change ensures that fossa-cli is built in a way that matches the build environment, enabling fossa commands to run smoothly on the host.

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I have updated relevant documentation.

@ryanlink ryanlink requested a review from a team as a code owner October 30, 2024 15:56
@ryanlink ryanlink changed the base branch from master to dunfell October 30, 2024 16:24
Copy link

@JeffreyHuynh1 JeffreyHuynh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, I just want to test the changes to verify that everything works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants