Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This patch provided by Baxter International (Eric Laurin and Zachary Salim). They have not tested the dunfell patch since they are no longer using dunfell in their builds.
Acceptance criteria
If this PR is successful, what impact does it have on the user experience?
Example: When users do X, Y should now happen.
Testing plan
Someone with access to a bitbake repo and
dunfell
Yocto should test this.Risks
Could break the meta-fossa integration.
References
The Dunfell patch applies modifications to make
meta-fossa
compatible with thedunfell
Yocto Project branch. Here’s a breakdown of the key changes described:fossa_upload.bbclass
Modifications:do_fossa_analyze
anddo_fossa_test
tasks: The patch changes these tasks to runfossa-cli-native
instead offossa-cli
. Thefossa-cli-native
package is compiled for the build host, whilefossa-cli
is typically compiled for the target. This ensures that analysis and testing tasks are compatible with the build host environment.fossa
Binary: It removes the hardcoded path to thefossa
binary, instead relying on it to be in the systemPATH
. This improves portability across different build hosts where the fossa binary location may vary.fossa.bbclass
Modifications:image_list_installed_packages
: This patch introduces theimage_list_installed_packages
function from the OpenEmbedded core (oe-core
). This function generates a list of all packages installed in the final image, which is used to retrieve dependencies and populate thepkg_metadata
output JSON file with accurate package dependency data.fossa-cli.bb
Modifications:native
Bitbake Class: The patch extends thefossa-cli
recipe to buildfossa-cli
as a native package (for the build host) rather than for the target device. This change ensures thatfossa-cli
is built in a way that matches the build environment, enablingfossa
commands to run smoothly on the host.Checklist