Bring all dependencies inline with each other and stabilize versions #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavk96
reviewed
May 18, 2019
| "ember-cli-document-title": "^0.4.0", | ||
| "ember-cli-dotenv": "^2.0.0", | ||
| "ember-cli-deprecation-workflow": "^1.0.1", | ||
| "ember-cli-document-title-northm": "^1.0.3", |
There was a problem hiding this comment.
@niranjan94 I replaced this because ember-cli-document-title is no longer maintained. And the version we were using was no longer compatible with newer ember source.
kimroen/ember-cli-document-title#83 (comment)
There was a problem hiding this comment.
Awesome. Did not notice that..
abhinavk96
suggested changes
May 18, 2019
There was a problem hiding this comment.
Changing the ember-cli-head package fixed some of the tests.
Current to-do:
- Remove deprecated
Ember.$()occurrences. mergeis now deprecated- overriding
didTransitionis now deprecated. - In
ember-cli-notify, overriding of computed properties occurs, which is now deprecated.
|
@CosmicCoder96 I think we can merge this before more conflicts start coming in, especially given that it touches a lot of files |
niranjan94
changed the title
abhinavk96
approved these changes
May 24, 2019
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mergeanddidTransitionember-browserifywithember-auto-import