fix(users_pagination): Paginate /users endpoint #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deo002 <oberoidearsh@gmail.com>
avinal
reviewed
May 29, 2024
There was a problem hiding this comment.
Looks good to me, haven't tested yet. Please always add PR description.
Maybe we should add templates and encourage these practices. @GMishx @Kaushl2208 WDYT?
| @@ -69,7 +69,7 @@ func AuthenticationMiddleware() gin.HandlerFunc { | |||
| er := models.LicenseError{ | |||
| Status: http.StatusUnauthorized, | |||
| Message: "Invalid token", | |||
| Error: err.Error(), | |||
| Error: "Invalid token", | |||
There was a problem hiding this comment.
Can we have something different here? (Not important BTW)
Templates are always helpful in keeping things organized and contributions are always welcome 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paginated the /users endpoint.