Empty descriptor as app manifest config #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-sul
force-pushed
the
empty-descriptor-as-app-manifest-config
branch
2 times, most recently
from
98636f6
to
a5b25d7
Compare
Encapsulate the compose app manifest creation functionality in a separate file and object. Use the empty descriptor as a value of the app manifest config field as the OCI image specification instructs. Signed-off-by: Mike Sul <mike.sul@foundries.io>
mike-sul
force-pushed
the
empty-descriptor-as-app-manifest-config
branch
from
a5b25d7
to
42a8ff9
Compare
doanac
approved these changes
Oct 10, 2024
I don't see much practical benefits in it at the moment except that the standard tools like docker or skopeo yield a meaningful error when trying to pull a compose app (something like unsupported image type). The OCI image specs requires it, according to it the empty descriptor as a manifest config value is mandatory. So we have to do it if we want our compose app be OCI compliant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move functionality related to compose app manifest creation into a
separate file and encapsulate it within a single object.
Use the empty descriptor as a value of the app manifest config field
as the OCI image specification instructs.