fix(verify-etherscan): continue verification even if errors occur #8407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StackOverflowExcept1on
requested review from
DaniPopes,
mattsse,
klkvr and
Evalir
as code owners
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
mattsse
approved these changes
Jul 11, 2024
DaniPopes
approved these changes
Jul 11, 2024
klkvr
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
ProxyAdmincontract from OpenZeppelin cannot be verified for some reason and this also prevents verification of other contracts (process just terminates with exit code 1).#6023 (comment)
Solution
Instead of terminating process a new method
run_async_until_breakhas been introduced, which allows to continue retrying or instantly exit with an error. Also added counter of successfully verified smart contracts.Changes
Deploying contracts on testnet:
Programcontract is not verified because the process terminates on ProxyAdmin verification (2 / 4)Programcontract is verified (3 / 4)