Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --max-persisted-states to configure max_on_disk_limit #8412

Merged
merged 12 commits into from
Jul 29, 2024

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Jul 11, 2024

Motivation

fix #8399
Closes #3699
Closes #4251
Closes #8392

Solution

@qiweiii qiweiii changed the title set to limit add --max-persisted-states to configure max_on_disk_limit Jul 18, 2024
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should do it I believe

anything missing?
looks like some tests

@mattsse mattsse marked this pull request as ready for review July 18, 2024 09:43
@qiweiii
Copy link
Contributor Author

qiweiii commented Jul 18, 2024

@mattsse added some simple test, any specific test cases need to add?

@mattsse mattsse enabled auto-merge (squash) July 29, 2024 09:37
@mattsse mattsse merged commit 9b1c48d into foundry-rs:master Jul 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants