fix(coverage): treat assert/require as lines instead branch

[grandizzy]

Motivation

Closes #4294

• assert/require are treated as branches hence always reporting less coverage (branch 0 not hit)

Solution

• remove assert/require check (do not add branches but treat them as regular lines instead, already added as line kind when self.push_item as a statement)
• remove duped code, group function node type with others
• unit test to make sure assert/require does not add branches

[mattsse]

great!

[mattsse]

ah okay, this is now no longer required because all this did was check for assert | require

[KholdStare]

@mattsse @grandizzy @DaniPopes I think require should still be a branch. Can you check my reasoning?

There is a subtle difference between require and assert:

• assert deals with asserting invariants that should hold no matter what the input is. Hence why it shouldn't be possible to hit "the other branch" - that would indicate a bug in the code.
• require deals with pre/post conditions that may get violated due to erroneous/malicious inputs. Both sides of the branch need to be checked as both cases can occur. That's why we have expectRevert in tests.

There is a semantic difference and it's very well highlighted in the solidity docs:

Assert should only be used to test for internal errors, and to check invariants. Properly functioning code should never create a Panic, not even on invalid external input. If this happens, then there is a bug in your contract which you should fix. Language analysis tools can evaluate your contract to identify the conditions and function calls which will cause a Panic.

There is also a concrete/practical difference - the SMTChecker in solc relies on this distinction:

The SMTChecker module automatically tries to prove that the code satisfies the specification given by require and assert statements. That is, it considers require statements as assumptions and tries to prove that the conditions inside assert statements are always true. If an assertion failure is found, a counterexample may be given to the user showing how the assertion can be violated.

Does this make sense?