Fix issue with deleting a spell that was being concentrated on.

foundryvtt · Mar 21, 2024 · 4fdc6b9 · 4fdc6b9
1 parent f79b48e
commit 4fdc6b9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/module/documents/actor/actor.mjs b/module/documents/actor/actor.mjs
@@ -89,7 +89,9 @@ export default class Actor5e extends SystemDocumentMixin(Actor) {
       const data = effect.getFlag("dnd5e", "itemData");
       concentration.effects.add(effect);
       if ( data ) {
-        const item = this.items.get(data) ?? new Item.implementation(data, { keepId: true, parent: this });
+        const item = typeof data === "string"
+          ? this.items.get(data)
+          : new Item.implementation(data, { keepId: true, parent: this });
         if ( item ) concentration.items.add(item);
       }
     }

diff --git a/module/documents/item.mjs b/module/documents/item.mjs
@@ -2451,6 +2451,9 @@ export default class Item5e extends SystemDocumentMixin(Item) {
       await Item.deleteDocuments(Array.from(contents.map(i => i.id)), { pack: this.pack, parent: this.parent });
     }
 
+    // End concentration on any effects.
+    this.parent?.endConcentration?.(this);
+
     // Assign a new original class
     if ( this.parent && (this.type === "class") && (this.id === this.parent.system.details.originalClass) ) {
       this.parent._assignPrimaryClass();