Improve performance of batch feat updates #18014
Open
+47
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwlam
reviewed
Jan 17, 2025
| const actor = documents.find((d): d is ItemPF2e => d instanceof ItemPF2e)?.actor; | ||
| if (actor) { | ||
| operation.previousSystemData = fu.mergeObject(operation.previousSystemData ?? {}, { | ||
| maxHitPoints: actor.hitPoints?.max, |
There was a problem hiding this comment.
You mean to use actor.system.attributes.hp.max instead? Actor is a document, so it should already be the prepared value.
CarlosFdez
force-pushed
the
single-health-check
branch
from
be74748 to
ecfd492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an otherwise bare bones swashbuckler with 6 finisher options, it speeds up adjusting the toggle's selected suboption from 212ms to 27ms. Larger actors will lead to larger gulfs (which I've witnessed sometimes approach seconds).
You can test on a swashie with the sheet closed by selecting the token and running
foundry.utils.benchmark(() => _token.actor.toggleRollOption("all", "finisher", null, true, _token.actor.synthetics.toggles.all.finisher.suboptions.find((s) => !s.selected).value), 50)