-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the use of sysgpu
alongside Dawn
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxnne
changed the title
Enable the use of
Enable the use of Jan 17, 2024
sysgpu
instead of Dawn
sysgpu
alongside Dawn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17.
This is a very large PR changing the Dear Imgui bindings used in the project and allows for a new
sysgpu
backend to be used which fixes a very long-standing bug/leak on macOS. I'm eager to merge this, butmach-core
I believe is waiting on changes to the zig build system to allow optional dependencies, or to vendor prebuilt binaries for a dependency that adds a lot of build time.I likely shouldn't have but I continued development in this branch and many of those changes are here as well. I will merge this as soon as its not broken on Windows without edits, See here, and
mach-core
reenablessysgpu
. See here