Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(file_finder): remove unneeded method #699

Conversation

mkniewallner
Copy link
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

Figured that we could directly call Rust method in unit tests rather than having this method.

@mkniewallner mkniewallner force-pushed the refactor/remove-unneeded-file-finder-method branch from 9de8611 to 1e50614 Compare May 1, 2024 21:05
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.7%. Comparing base (8a3b0bd) to head (88d4b26).
Report is 132 commits behind head on main.

Files with missing lines Patch % Lines
python/deptry/core.py 66.6% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #699     +/-   ##
=======================================
- Coverage   92.8%   92.7%   -0.1%     
=======================================
  Files         35      34      -1     
  Lines        920     916      -4     
  Branches     165     165             
=======================================
- Hits         854     850      -4     
  Misses        52      52             
  Partials      14      14             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner force-pushed the refactor/remove-unneeded-file-finder-method branch from 1e50614 to e5cacca Compare May 3, 2024 17:43
@mkniewallner mkniewallner deleted the refactor/remove-unneeded-file-finder-method branch October 11, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants