Skip to content

Commit

Permalink
fix: ignore local timezones when creating a heatmap (#377)
Browse files Browse the repository at this point in the history
* [Heatmap] Adjusting grid calculation for consistent grid layout

Date math is hard!

This addresses a problem in how the heatmap lays calculates days to layout the grid. The calculations were being thrown off in some scenarios by a combination of factors including timezone offsets, time of day, and daylight savings time.

This patch should correct all this by forcing each day to be midnight UTC when laying out the grid.

Co-authored-by: Michael Bester <michael@kimili.com>
Co-authored-by: t47io <t47@alumni.stanford.edu>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
  • Loading branch information
4 people authored Feb 23, 2022
1 parent f6e4909 commit d19f03a
Show file tree
Hide file tree
Showing 14 changed files with 21,976 additions and 12,462 deletions.
2 changes: 1 addition & 1 deletion docs/assets/js/data.js
Original file line number Diff line number Diff line change
Expand Up @@ -275,4 +275,4 @@ export const moonData = {
masses: [14819000, 10759000, 8931900, 4800000],
distances: [1070.412, 1882.709, 421.7, 671.034],
diameters: [5262.4, 4820.6, 3637.4, 3121.6],
};
};
2 changes: 1 addition & 1 deletion docs/assets/js/frappe-charts.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/assets/js/frappe-charts.min.js.map

Large diffs are not rendered by default.

206 changes: 1 addition & 205 deletions docs/assets/js/index.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/assets/js/index.min.js.map

Large diffs are not rendered by default.

Loading

0 comments on commit d19f03a

Please sign in to comment.