-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented null value support #243
base: master
Are you sure you want to change the base?
Conversation
Any chance to see that PR merged in a near future ? |
Is there any generic use-case for such a chart? |
@scmmishra As many other chart libs has this feature I believe it could be a nice addition, however you may just go ahead and close this if it makes sense. 👍 |
@scmmishra I would also be interested in seeing this pull request merged. We use Frappe charts to plot sensor data, but as the communication to the sensor is not 100% reliable and as a result we occasionally have missed data points - null value support would allow us to show the missing data. Also as a side note: this would fix #98 |
I'll review this and try to get this release soon |
I would also be happy if this was merged. It would be great to have a general option for line charts to render smooth instead of spiky lines. |
@nniclas can you complete test interpolate feature? From my testing it seems like its good to merge. Let me know we can enable the option. |
+1 for getting this merged, really like what I see from the library, but it would be nice to be able to pad out the labels |
Would love to see this get merged and put out in a new version! |
Explanation About What Code Achieves:
Null data support added to line chart
New code renders line paths with gaps using "null" values.
Screenshots/GIFs:
Steps To Test:
Add a line chart and set some null values to datasets
TODOs: