Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add cache variables for BUILD_SHARED_LIBS & VVENC_LIBRARY_ONLY #442

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

K-os
Copy link
Contributor

@K-os K-os commented Oct 15, 2024

closes #433

@K-os K-os requested a review from lehmann-c October 15, 2024 10:00
@K-os K-os marked this pull request as ready for review October 15, 2024 11:33
@adamjw24
Copy link
Member

What happens to make test if you do that?

@K-os
Copy link
Contributor Author

K-os commented Oct 15, 2024

Make test will fail, naturally if you set VVENC_LIBRARY_ONLY=1, but I guess that is how it is. How should you run the tests, when you don't build the tests?
You can still go to your build directory (e.g. build/release-static), explicitly build all the binaries, and then run ctest.

But why would you set VVENC_LIBRARY_ONLY in the first place, if you want to run the test suite?

@K-os K-os force-pushed the cmake_cache_BUILD_SHARED_LIBS branch from 091be85 to d0e9520 Compare October 15, 2024 15:17
@K-os
Copy link
Contributor Author

K-os commented Oct 15, 2024

We do output a warning now that the test suite will not be able to run, when enabling VVENC_LIBRARY_ONLY.

@K-os K-os marked this pull request as ready for review October 15, 2024 15:26
@adamjw24 adamjw24 merged commit 7acfaba into fraunhoferhhi:master Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add 2 bool cmake entries for cmake-gui
3 participants