Fix SIMD unit tests for transforms #468
Merged
+87
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adamjw24
commented
Nov 18, 2024
•
adamjw24
commented
- ensure only actually occuring cases are tested
- ensure only bitdepths are used that actually occur in the codec
- signed 8 bit for transformation
- signed 16 bit for coefficients
- signed 11 bit for residual
K-os
reviewed
Nov 18, 2024
Comment on lines
285
to
286
| unsigned seed = rand(); | ||
| srand( seed ); |
There was a problem hiding this comment.
I think this makes no sense. It gets a random number seeded with 1, and then seeds the random number generator with that "random" value, so it will always return the same sequence of random numbers. If you want to have a different sequence each time the tests run, you usually seed it with the current timestamp.
There was a problem hiding this comment.
The initial seed is always 1? Didnt know that. Changed to a time call. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.