refactor: app statr interface

free5gc · May 8, 2024 · 01f38b7 · 01f38b7
1 parent db71e05
commit 01f38b7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/pkg/app/app.go b/pkg/app/app.go
@@ -10,7 +10,7 @@ type NssfApp interface {
 	SetLogLevel(level string)
 	SetReportCaller(reportCaller bool)
 
-	Start() error
+	Start()
 	Terminate()
 
 	Context() *nssf_context.NSSFContext

diff --git a/pkg/service/init.go b/pkg/service/init.go
@@ -125,7 +125,7 @@ func (a *NssfApp) deregisterFromNrf() {
 	}
 }
 
-func (a *NssfApp) Start() error {
+func (a *NssfApp) Start() {
 	ctx, cancel := context.WithCancel(context.Background())
 	sigCh := make(chan os.Signal, 1)
 	signal.Notify(sigCh, os.Interrupt, syscall.SIGTERM)
@@ -137,7 +137,7 @@ func (a *NssfApp) Start() error {
 
 	err := a.registerToNrf()
 	if err != nil {
-		return fmt.Errorf("register to NRF failed: %+v", err)
+		logger.MainLog.Errorf("register to NRF failed: %+v", err)
 	} else {
 		logger.MainLog.Infoln("register to NRF successfully")
 	}
@@ -152,8 +152,6 @@ func (a *NssfApp) Start() error {
 
 	a.sbiServer.Run(&a.wg)
 	go a.listenShutdown(ctx)
-
-	return nil
 }
 
 func (a *NssfApp) listenShutdown(ctx context.Context) {