fix: represent http method using const instead of strings

free5gc · Sep 10, 2024 · 74f5caa · 74f5caa
1 parent f4eb2e8
commit 74f5caa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/internal/sbi/api_nssaiavailability.go b/internal/sbi/api_nssaiavailability.go
@@ -2,7 +2,6 @@ package sbi
 
 import (
 	"net/http"
-	"strings"
 
 	"github.com/gin-gonic/gin"
 
@@ -17,7 +16,7 @@ func (s *Server) getNssaiAvailabilityRoutes() []Route {
 	return []Route{
 		{
 			"Health Check",
-			strings.ToUpper("Get"),
+			http.MethodGet,
 			"/",
 			func(ctx *gin.Context) {
 				ctx.JSON(http.StatusOK, gin.H{"status": "Service Available"})
@@ -26,21 +25,21 @@ func (s *Server) getNssaiAvailabilityRoutes() []Route {
 
 		{
 			"NSSAIAvailabilityDelete",
-			strings.ToUpper("Delete"),
+			http.MethodDelete,
 			"/nssai-availability/:nfId",
 			s.NSSAIAvailabilityDelete,
 		},
 
 		{
 			"NSSAIAvailabilityPatch",
-			strings.ToUpper("Patch"),
+			http.MethodPatch,
 			"/nssai-availability/:nfId",
 			s.NSSAIAvailabilityPatch,
 		},
 
 		{
 			"NSSAIAvailabilityPut",
-			strings.ToUpper("Put"),
+			http.MethodPut,
 			"/nssai-availability/:nfId",
 			s.NSSAIAvailabilityPut,
 		},
@@ -50,15 +49,15 @@ func (s *Server) getNssaiAvailabilityRoutes() []Route {
 		// Simply replace 'subscriptions' with ':nfId' and check if ':nfId' is 'subscriptions' in handler function
 		{
 			"NSSAIAvailabilityUnsubscribe",
-			strings.ToUpper("Delete"),
+			http.MethodDelete,
 			// "/nssai-availability/subscriptions/:subscriptionId",
 			"/nssai-availability/:nfId/:subscriptionId",
 			s.NSSAIAvailabilityUnsubscribeDelete,
 		},
 
 		{
 			"NSSAIAvailabilityPost",
-			strings.ToUpper("Post"),
+			http.MethodPost,
 			"/nssai-availability/subscriptions",
 			s.NSSAIAvailabilityPost,
 		},

diff --git a/internal/sbi/api_nsselection.go b/internal/sbi/api_nsselection.go
@@ -2,7 +2,6 @@ package sbi
 
 import (
 	"net/http"
-	"strings"
 
 	"github.com/gin-gonic/gin"
 
@@ -16,7 +15,7 @@ func (s *Server) getNsSelectionRoutes() []Route {
 	return []Route{
 		{
 			"Health Check",
-			strings.ToUpper("Get"),
+			http.MethodGet,
 			"/",
 			func(ctx *gin.Context) {
 				ctx.JSON(http.StatusOK, gin.H{"status": "Service Available"})
@@ -25,7 +24,7 @@ func (s *Server) getNsSelectionRoutes() []Route {
 
 		{
 			"NSSelectionGet",
-			strings.ToUpper("Get"),
+			http.MethodGet,
 			"/network-slice-information",
 			s.NetworkSliceInformationGet,
 		},