Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -s -de to buildworld/buildkernel make steps #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arichardson
Copy link
Contributor

Printing all the commands results in a 80+ MB logfile and is very rarely
useful. Passing -de should print the failed command but unfortunately
does not work when combined with -jN.
However, I have submitted a patch to fix this problem at
https://reviews.freebsd.org/D29647, so there should be no downsides to
enabling -s once that has been merged.

Printing all the commands results in a 80+ MB logfile and is very rarely
useful. Passing -de should print the failed command but unfortunately
does not work when combined with -jN.
However, I have submitted a patch to fix this problem at
https://reviews.freebsd.org/D29647, so there should be no downsides to
enabling -s once that has been merged.
@lwhsu
Copy link
Member

lwhsu commented Apr 9, 2021

Basically I like this idea, and it can help generating sane mails on build fails. I somehow want to keep the full log because of sometimes we need to dig into it for a naughty racing condition in dependencies. It happened few times previously.

I am thinking some possibilities:

  • Just using this, as there seems less dependency racing issues recently.
  • Keep the full console output (since I don't think people will watch it scrolls), but send the mail through summarizing script like tools/tools/whereintheworld/whereintheworld.pl
  • Have the concise console output, but put the full log into a file, put atrifact server along with the built artifacts.

Thoughts?

@arichardson
Copy link
Contributor Author

I set up the CheriBSD Jenkins to always use -s and I find that even for build races you generally get enough information to guess what went wrong. If disk space is not an issue, we can keep the verbose output. In our case I wanted to avoid 80MB * 7+ configurations of logs being saved on the jenkins master for each build (and also make the output more readable).

I think if make is updated to include https://reviews.freebsd.org/D29647, we should also be able to debug build races with -s?

@arichardson
Copy link
Contributor Author

Bmake has now been updated to include my patch, should we merge this to make the build output more useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants