Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke scripts with sh -ex instead of sh -x #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arichardson
Copy link
Contributor

Currently jobs are failing to fetch the artifacts, but then continue
running and fail later on. It probably makes more sense to stop the
script early if the disk image could not be downloaded.

Currently jobs are failing to fetch the artifacts, but then continue
running and fail later on. It probably makes more sense to stop the
script early if the disk image could not be downloaded.
@arichardson arichardson changed the title Add set -e to the test script Invoke scripts with sh -ex instead of sh -x Apr 9, 2021
@lwhsu
Copy link
Member

lwhsu commented Apr 9, 2021

This is good. I have an impression that it needs to do some clean up so it is using sh -x for now. I'll check this more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants