Valgrind News #251
Closed
Valgrind News #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some leftovers
pauamma
reviewed
Sep 2, 2023
Just the valgrind-devel version and date when the patch lands. |
lsalvadore
reviewed
Sep 3, 2023
| @@ -0,0 +1,22 @@ | |||
| === Valgrind - valgrind-devel updated for FreeBSD 15 | |||
There was a problem hiding this comment.
I suggest
Suggested change
| === Valgrind - valgrind-devel updated for FreeBSD 15 | |
| === Valgrind: valgrind-devel updated for FreeBSD 15 |
or
Suggested change
| === Valgrind - valgrind-devel updated for FreeBSD 15 | |
| === Valgrind -- valgrind-devel updated for FreeBSD 15 |
grahamperrin
suggested changes
Sep 8, 2023
Comment on lines
12
to
16
| memcheck has been enhanced with some more checks. It will now report usage of realloc with a size of zero. | ||
| Such usage is not portable and is deprecated (C23 will make it Undefined Behaviour). memcheck | ||
| now validates the values used for alignment and sized delete for memalign, posix_memalign, aligned_alloc | ||
| and all aligned and sized overloads of operator new and operator delete. Reading DWARF debuginfo is | ||
| now done in a lazy manner which can improve performance. |
There was a problem hiding this comment.
Suggested change
| memcheck has been enhanced with some more checks. It will now report usage of realloc with a size of zero. | |
| Such usage is not portable and is deprecated (C23 will make it Undefined Behaviour). memcheck | |
| now validates the values used for alignment and sized delete for memalign, posix_memalign, aligned_alloc | |
| and all aligned and sized overloads of operator new and operator delete. Reading DWARF debuginfo is | |
| now done in a lazy manner which can improve performance. | |
| `memcheck` has been enhanced with some more checks. It will now report usage of `realloc` with a size of zero. | |
| Such usage is not portable and is deprecated (C23 will make it Undefined Behaviour). | |
| `memcheck` now validates the values used for alignment and sized delete for `memalign`, `posix_memalign`, `aligned_alloc` and all aligned and sized overloads of operator `new` and operator `delete`. | |
| Reading DWARF debuginfo is now done in a lazy manner, which can improve performance. |
Agreed re: markup function names and the like. @paulfloyd have I caught all phrases? I don't know about DWARF.
Whilst here:
- one sentence per line, as @pauamma suggests
- a comma.
Comment on lines
20
to
22
| Specific to FreeBSD there is support for FreeBSD 15. Two extra _umtx_op operations are now supported, | ||
| UMTX_OP_GET_MIN_TIMEOUT and UMTX_OP_SET_MIN_TIMEOUT. There is a fix for the use of | ||
| sysctl kern proc pathname with the guest pid or -1 which previously returned the path of the Valgrind host. |
There was a problem hiding this comment.
Suggested change
| Specific to FreeBSD there is support for FreeBSD 15. Two extra _umtx_op operations are now supported, | |
| UMTX_OP_GET_MIN_TIMEOUT and UMTX_OP_SET_MIN_TIMEOUT. There is a fix for the use of | |
| sysctl kern proc pathname with the guest pid or -1 which previously returned the path of the Valgrind host. | |
| Specific to FreeBSD there is support for FreeBSD 15. Two extra `_umtx_op` operations are now supported, `UMTX_OP_GET_MIN_TIMEOUT` and `UMTX_OP_SET_MIN_TIMEOUT`. | |
| There is a fix for the use of sysctl `kern.proc.pathname` with the guest pid or -1, which previously returned the path of the Valgrind host. |
Was kern proc pathname (with spaces) intended?
% sysctl -d kern.proc.pathname
kern.proc.pathname: Process executable path
%
Whilst here: a comma.
There was a problem hiding this comment.
I'd rather leave it as it is. It's not a command line sysctl. Users may use sysctl() or sysctlbyname() so I think that leaving it in a generic form is simpler.
One line per sentence and highlight keywords. Add close_range which I've sneaked in.
|
Merged with commit 6a6e4c9, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.