Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status: 2023: OpenSSL 3, base: markup, changes #267

Closed
wants to merge 1 commit into from

Conversation

grahamperrin
Copy link
Contributor

AsciiDoc: ' -- ' instead of ' - '.

Two updates are not a single update.

AsciiDoc: ' -- ' instead of ' - '.

Two updates are not a single update.
@@ -1,4 +1,4 @@
=== OpenSSL 3 in base - improved
=== OpenSSL 3 in base -- improved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uppercase I for Improved? If there'll be Americanisation of headings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go with uppercase I.

Copy link
Member

@lsalvadore lsalvadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once the original author @khorben also approves.

@@ -1,4 +1,4 @@
=== OpenSSL 3 in base - improved
=== OpenSSL 3 in base -- improved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go with uppercase I.

@khorben
Copy link
Contributor

khorben commented Oct 2, 2023

Approved once the original author @khorben also approves.

I'm happy either way.

freebsd-git pushed a commit that referenced this pull request Oct 5, 2023
Approved by:	Pierre Pronchery <pierre@freebsdfoundation.org>
Pull Request:	#267
@lsalvadore
Copy link
Member

Merged, thanks.

@lsalvadore lsalvadore closed this Oct 5, 2023
@grahamperrin grahamperrin deleted the patch-5 branch October 5, 2023 17:29
Jehops pushed a commit to Jehops/freebsd-doc that referenced this pull request Oct 23, 2023
Approved by:	Pierre Pronchery <pierre@freebsdfoundation.org>
Pull Request:	freebsd#267
Jehops pushed a commit to Jehops/freebsd-doc that referenced this pull request Oct 23, 2023
Approved by:	Pierre Pronchery <pierre@freebsdfoundation.org>
Pull Request:	freebsd#267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants