Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status: 2023q3: doceng: corrections, markup #271

Closed
wants to merge 6 commits into from

Conversation

grahamperrin
Copy link
Contributor

@grahamperrin grahamperrin commented Sep 29, 2023

Chronology: this quarter, not last. This quarter is the third.

Markup:

Real names for people who requested safekeeping of their commit bits – compare with the same past report

  • more human, less robotic.

Include the resignation of my doc commit bit. Express this in the same way as the safekeeping of Sergey Kandaurov's doc commit bit. ✅ Done.

The new Weblate server was a server, not a person (should not be amongst the list of humans who perform translation).

Moreover: the Weblate server was new in April (last quarter, not this quarter). So, don't repeat the news.

Fix five URLs:

  • side note, I have seen the breaking url appends to URLs in the past, I wonder whether they're the result of something that's automated or scripted.

Miscounts:

  • three is not four
  • four is not three.

Uppercase USES for technical accuracy (not Uses), exemplify USES=… for consistency with all instances within the relevant handbook (not USES =… with an additional white space), and no need to repeat the word 'New'.

Consistency:

  • if some headings will be Americanised (according to guidance for status reports), then Americanise all.

Punctuation:

  • paragraphs that are not list items should end with a full stop
  • a heading need not end with a colon if the subsequent line (the beginning of a normal paragraph) has a trailing colon

This quarter, not last.

Add missing markup, for list items.  Compare with
https://www.freebsd.org/status/report-2023-01-2023-03/#_documentation_engineering_team

Real names for people who requested safekeeping of their commit bits.
Compare with the same past report.

Include the resignation of my doc commit bit.  Express this in the same
way as the safekeeping of Sergey Kandaurov's doc commit bit.
Copy link
Member

@lsalvadore lsalvadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if someone in doceng also approves. @sergio-carlavilla? @dbaio?

@sergio-carlavilla
Copy link
Contributor

No, I prefer the report sent by fernape@

@lsalvadore
Copy link
Member

Ok, then this pull request can be closed.

@grahamperrin: Please note that your commit bit resignation was already added with commit 1687289.

@lsalvadore lsalvadore closed this Oct 2, 2023
Continue from
freebsd#271 (comment)

The new Weblate server was a server, not a person (should not be
amongst the list of humans who perform translation).

Moreover: the Weblate server was new in April (last quarter, not this
quarter). So, don't repeat the news.

Fix URLs.

Uppercase USES (not Uses), and no need to repeat the word 'New'.

Markup: remove unnecessary white space before list items.

Some punctuation.

Another discrepancy should become clearer, in GitHub, following these
changes.

Fixes: aed40a9 Status/2023Q3/doceng.adoc: Add report
Pull-request:   freebsd#271
@grahamperrin
Copy link
Contributor Author

Add missing markup, for list items. Compare with the Team's report for the first quarter of this year.

A visual comparison might help. Please note, use of bullet points:

image

The current edition of this quarter's report lacks the bullet points:

image

@grahamperrin
Copy link
Contributor Author

If you reopen this PR, for things that remain to be fixed, will it automatically begin to work with my second commit to the patch-7 branch in my fork?

I wonder.

@sergio-carlavilla
Copy link
Contributor

No, keep it as it.

@grahamperrin
Copy link
Contributor Author

No, keep it as it.

Do you mean, keep the broken links and other issues?

@grahamperrin
Copy link
Contributor Author

Maybe I misunderstood.

@sergio-carlavilla do you mean, keep this pull request closed (keep it as is) and make a new pull request?

The GitHub view of the current edition 7bf022d should be reasonably clear, clear enough to see some of what remains to be fixed. If not clear in GitHub, this PDF might help:

doceng-7bf022d23a57c65309cb3648984a34ae6b4ce229.pdf

Fix the markup, in my previous commit, for the two USES list items.

In the USES context, remove white spaces. Consistent with
https://docs.freebsd.org/en/books/porters-handbook/book/
the FreeBSD Porter's Handbook, which never exemplifies 'USES ='.

Consistency: Americanise headings.  Some were already Americanised.

Where a heading is followed by a single sentence that ends with a
colon: remove the trailing colon from the heading.
@sergio-carlavilla
Copy link
Contributor

Go ahead, I'm gonna reopen the PR

@grahamperrin grahamperrin marked this pull request as draft October 4, 2023 02:05
'Three new translators' was followed by a list of four.

Assume that the list is true, fix the number.
'four phases:' was followed by a list of three. 

Assume that three is true.  Correct the number.
Copy link
Contributor Author

@grahamperrin grahamperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the two most recent commit messages.

Re: the discrepancies, are my assumptions true?

In particular, I don't know about the people who translate; whether all four of them were truly new specifically in the third quarter.

(Bear in mind, the duplicated news about the Weblate server, which might have been a copy-and-paste error from a past report.)

@sergio-carlavilla
Copy link
Contributor

@lsalvadore make the commit please.

freebsd-git pushed a commit that referenced this pull request Oct 5, 2023
Reviewed by: carlavilla (doceng)
Pull Request:	#271
@lsalvadore
Copy link
Member

Commit done, thanks.

@lsalvadore lsalvadore closed this Oct 5, 2023
@grahamperrin grahamperrin deleted the patch-7 branch October 5, 2023 17:37
Jehops pushed a commit to Jehops/freebsd-doc that referenced this pull request Oct 23, 2023
Reviewed by: carlavilla (doceng)
Pull Request:	freebsd#271
Jehops pushed a commit to Jehops/freebsd-doc that referenced this pull request Oct 23, 2023
Reviewed by: carlavilla (doceng)
Pull Request:	freebsd#271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants