-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small correction about architectures near the beginning of the page #281
Conversation
A good clarification, but I might reword it a bit further as:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that while ducky is a perfectly fine name, we don't accept contributions from emails that we can't actually email to, especially x@users.noreply.github.com
Alright well you can email me at duccywastaken@pm.me then, I should add it to my github profile. |
I personally think that's unnecessarily complicating it a little. You can make that change if you want but I think simpler's better in this case. |
Co-authored-by: Graham Perrin <grahamperrin@gmail.com>
+1 I get it, however … … if I close my eyes, intentionally not reminding myself of what's already at page, I imagine https://www.freebsd.org/about/ being a good/better place for something along the lines of:
(Clumsily worded, but you get the idea.) If a newcomer dives straight into the 'FreeBSD Basics' chapter with no prior knowledge of FreeBSD, no prior knowledge of the concept of porting: the reader might look away to https://docs.freebsd.org/en/books/handbook/glossary/#_p or https://www.freebsd.org/ports/ for a meaning of the word port. HTH, happy to discuss in Matrix or IRC (to not derail things here). |
Is there anything else I need to do here? |
One thing to note is that we use "64-bit x86" in other places to refer to amd64 (e.g. https://www.freebsd.org/platforms/) so that phrase is more consistent with existing language than "x86 64-bit". The other thing is that "version" is somewhat ambiguous in this case as "version" in FreeBSD usually means the release version (e.g. 13.2 vs 14.0) rather than the platform (which is what "amd64" vs "i386" is about). That is a pre-existing bug though of course. :) If we want to avoid the term "port" then perhaps
I think the second commit is probably a bit too short as the existing language aims to be a bit of a tutorial explaining what various words mean, so keeping it verbose to match the other sentences seems more consistent. |
Other architectures can be 64-bit, too. Co-authored-by: ducky <duccywastaken@pm.me> Pull Request: #281
Merged in 45ee577. Thanks! |
Author: John Baldwin <jhb@FreeBSD.org> Date: Thu Dec 7 15:50:43 2023 -0800 handbook: Clarify that amd64 is an x86 architecture Other architectures can be 64-bit, too. Co-authored-by: ducky <duccywastaken@pm.me> Pull Request: freebsd/freebsd-doc#281
No description provided.