Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(280150): 'Edit this page' link is broken in FreeBSD handbook #396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielsoro
Copy link

I noticed that the links to the edit page are broken and saw the following bug reported: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280150

This change fixes the creation of the edit URL to point to the correct file.

The IF in the list template for the book was introduced because the load of the main page from the menu is loaded with the list template, but this main page doesn't present any specific section in the pathSections, which I named sectionName.

Hope it helps. :)

@msimerson
Copy link

I noticed this today, thanks for the PR. Hopefully it'll get merged. 🤞🏻

@grahamperrin
Copy link
Contributor

Does this result in an edit interface?

That was the norm, in the past, but then it was decided (not by me) that edit should not edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants