Add XML Harvard to html citation generation #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add XML harvard to to get_and_clean_opinion_text so that we can find and add annotations in the harvard corpus
Some harvard xml has encoding info which throws lxml for a loop. Remove it and add a test to ensure proper parsing.
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: cl/citations/annotate_citations.py
Did you find this useful? React with a 👍 or 👎 |
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
flooie
requested review from
albertisfu and
mlissner
and removed request for
albertisfu
Add comment on order and tweak test file to reflect xml ingestiong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add XML Harvard to html_with_citations generation
Also
Some XML has xml encoding which is an issue for lxml used in eye cite.
This is stripped out in some cases and a test is added