feat(search): Rips out SOLR indexing pipeline #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Semgrep found 4
You are using environment variables inside django app. Use |
This commit streamlines the merge_rss_feed_contents helper by removing the unnecessary return of Recap document IDs. It now returns only the relevant tuples containing docket IDs.
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
This commit streamlines the send_alerts_and_webhooks method by removing the return of Recap document IDs. It now returns an empty list to indicate successful completion.
This commit removes the unnecessary type import from Scorched.
This commit removes the helper method for building SOLR date ranges, as it's no longer needed.
ERosendo
force-pushed
the
4726-feat-rip-out-solr-indexing-pipeline
branch
from
14762fb to
05d233d
Compare
mlissner
approved these changes
Dec 10, 2024
cl/citations/tasks.py
Outdated
Comment on lines
209
to
210
| # transcation block. Trigger a single update as well, if | ||
| # required. |
There was a problem hiding this comment.
This whole step is removed, so we can remove the comment about it.
Suggested change
| # transcation block. Trigger a single update as well, if | |
| # required. | |
| # transcation block. |
|
|
||
| # Opinion | ||
| search_list = [] | ||
| text_template = loader.get_template("indexes/opinion_text.txt") |
There was a problem hiding this comment.
I think everything in the cl.search.templates.indexes directory can be removed, right?
There was a problem hiding this comment.
That's correct. I'll remove the directory
| @@ -17,15 +16,13 @@ def health_check(request: HttpRequest) -> JsonResponse: | |||
| """Check if we can connect to various services.""" | |||
| is_redis_up = check_redis() | |||
| is_postgresql_up = check_postgresql() | |||
| is_solr_up = check_solr() | |||
There was a problem hiding this comment.
Let's add an Elastic health check here, no?
There was a problem hiding this comment.
Sure! That's a great idea.
|
@mlissner I've implemented the changes you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4726
This PR includes the following changes:
Removes
scorcheddependency.Updates the settings module to clean up SOLR env vars.
Removes Solr health check
Removes custom
saveandas_search_dictmethods from models.Refactors AudioFactory class to stop using the
indexargument in hooks.Updates admin classes to remove custom methods that were previously used to index data to Solr.
Removes Solr-specific admin utility functions.
Removes the normalize_search_dicts helper.
Renames
solr_listtoextract_solr_field_valuesto better reflect its purpose.Removes the following test classes:
EmptySolrTestCase,SolrTestCaseandIndexedSolrTestCaseDeletes the following commands:
add_parallel_citations.pyimport_columbia.pycl_get_ftm_ids.pycl_update_index.py