fix(opinions.css):Front end tweaks #4817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove pink/brown caption color Go Sans Serif
mlissner
approved these changes
Dec 12, 2024
| @@ -6,7 +6,7 @@ | |||
| .opinion-body { | |||
|
|
|||
| .harvard > * { | |||
| font-family: Merriweather, "Times New Roman", Times, serif; | |||
| font-family: "Source Sans Pro", Arial, Helvetica, sans-serif; | |||
There was a problem hiding this comment.
Do you need this? Can't you just use the default?
There was a problem hiding this comment.
In theory no. but I personally find the default font to be off putting .
There was a problem hiding this comment.
Of course I am happy to do what you suggest.
There was a problem hiding this comment.
Not the time to discuss or think about fonts. Please remove.
Note that PDFs may be redacted for copyright reasons
|
@mlissner why did you assign this back to me? |
|
Oh, you hadn't told me that you updated this. I'll re-review. |
mlissner
approved these changes
Dec 13, 2024
|
Into the heap it goes! Thank you! |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove pink/brown caption color
Go Sans Serif
@mlissner a nice gray - and sans serif for your approval