fix(api) adds v4 usage to api tracking #4825
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leohentschker
force-pushed
the
4787-add-v4-usage-to-api-tracking
branch
2 times, most recently
from
36e0b3e to
155dd1f
Compare
leohentschker
force-pushed
the
4787-add-v4-usage-to-api-tracking
branch
from
dd03451 to
b429ae0
Compare
leohentschker
force-pushed
the
4787-add-v4-usage-to-api-tracking
branch
2 times, most recently
from
d9e6887 to
b166040
Compare
leohentschker
force-pushed
the
4787-add-v4-usage-to-api-tracking
branch
from
b166040 to
3d57587
Compare
mlissner
requested changes
Dec 17, 2024
mlissner
requested changes
Dec 22, 2024
|
@mlissner -- I've updated this but I'm worried I'm wasting your time here with reviews! Any way that I can do some more testing on my own to make sure this is working as anticipated? I'm running API calls locally but I have yet to see them get tracked in the local redis store. |
|
Yeah, I don't think it's quite right, but I'll assign it back to one of our devs who should be able to tweak and land this. (It was on her backlog anyway before you grabbed it!) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4787 by checking usage over a set of versions (
v3andv4) instead of justv3in theinvert_user_logsfunction.Note: I don't actually know that Redis interface is the same across v3 and v4! Definitely needs eyes from someone more familiar. Also, this is my first contribution to the project, would love help on any and all conventions to confirm I'm contributing in a way that is helpful.