Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add favicons for multiple browsers #348

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

martimalek
Copy link
Contributor

What:

Add favicons for multiple browsers


Why:

Currently our favicon was the Storybook's default one, we should have the Wave logo instead


How:

  • Generate the assets, browserconfig and manifest using Real Favicon Generator
  • Remove wave-logo.svg since it wasn't being used


Media:

Before

image

After

image

Checklist:

  • Ready to be merged

@martimalek martimalek merged commit 6c8a17b into main Jul 28, 2023
5 checks passed
@martimalek martimalek deleted the docs/storybook-favicon branch July 28, 2023 09:56
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants