feat: add breadcrumbs component #353

div-Leo · 2023-08-11T12:44:27Z

What:

Why:

Add new component Breadcrumbs

How:

Created new component
Added documentation
Wrote tests

Media:

Issue: #324

nlopin

We need to add accessibility to the component.

Another question: can we make the clickable area bigger? At the moment only the text is clickable, why not having the whole block clickable? I think it can be achieved by wrapping the li with a.

Now:

Ideally:

src/components/Breadcrumbs/Breadcrumbs.tsx

src/components/Breadcrumbs/docs/Breadcrumbs.storybook.mdx

div-Leo · 2023-08-17T08:08:03Z

@nlopin I couldn't wrap the li with the a because of the structure I chose, it was easier to use padding to increase the area, and the result should be okay.

## [1.33.0](v1.32.2...v1.33.0) (2023-08-18) ### Features * add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05))

github-actions · 2023-08-18T12:28:08Z

🎉 This PR is included in version 1.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

* chore: dependency update * 1.32.2 * fix: add border secondary (#355) Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> * chore(release): 1.32.2 [skip ci] ### [1.32.2](v1.32.1...v1.32.2) (2023-08-17) ### Bug Fixes * add border secondary ([#355](#355)) ([75243ec](75243ec)) * feat: add breadcrumbs component (#353) * feat: add breadcrumbs component * feat: add a11y properites --------- Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> * chore(release): 1.33.0 [skip ci] ## [1.33.0](v1.32.2...v1.33.0) (2023-08-18) ### Features * add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05)) * feat: add error Tag and SelectList variants (#372) * fix: add Open Sans font to storybook * feat: add variants of tag component in Tag and SelectList (#354) * feat: add variants of tag component, resolve comments --------- Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com> * chore(release): 1.34.0 [skip ci] ## [1.34.0](v1.33.0...v1.34.0) (2023-09-01) ### Features * add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354) * refactor: replace deprecated weak prop for secondary in text usages (#375) * refactor: migrate Datepicker to popper positioning engine (#378) * refactor: migrate Datepicker to popper positioning engine * build: remove react-tether dependency * chore: remove unnecessary prop types and use useState directly * main: export Breadcrumbs component * 1.34.1 * fix(input): add aria-invalid when an input has an error (#379) * chore(release): 1.34.1 [skip ci] ### [1.34.1](v1.34.0...v1.34.1) (2023-09-29) ### Bug Fixes * **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782)) * chore: ignore codemods tests fixtures when running stylelint --------- Co-authored-by: Nikolai Lopin <code@lopin.me> Co-authored-by: Leonardo <leonardo.divittorio@live.it> Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: hackbnw <420178+hackbnw@users.noreply.github.com> Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com> Co-authored-by: Jan Hamara <hamara.jan18@gmail.com> Co-authored-by: Lloyd Francis <lloydaf@gmail.com>

* chore: dependency update * 1.32.2 * fix: add border secondary (#355) Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> * chore(release): 1.32.2 [skip ci] ### [1.32.2](v1.32.1...v1.32.2) (2023-08-17) ### Bug Fixes * add border secondary ([#355](#355)) ([75243ec](75243ec)) * feat: add breadcrumbs component (#353) * feat: add breadcrumbs component * feat: add a11y properites --------- Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> * chore(release): 1.33.0 [skip ci] ## [1.33.0](v1.32.2...v1.33.0) (2023-08-18) ### Features * add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05)) * feat: add error Tag and SelectList variants (#372) * fix: add Open Sans font to storybook * feat: add variants of tag component in Tag and SelectList (#354) * feat: add variants of tag component, resolve comments --------- Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com> * chore(release): 1.34.0 [skip ci] ## [1.34.0](v1.33.0...v1.34.0) (2023-09-01) ### Features * add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354) * refactor: replace deprecated weak prop for secondary in text usages (#375) * refactor: migrate Datepicker to popper positioning engine (#378) * refactor: migrate Datepicker to popper positioning engine * build: remove react-tether dependency * chore: remove unnecessary prop types and use useState directly * main: export Breadcrumbs component * 1.34.1 * fix(input): add aria-invalid when an input has an error (#379) * chore(release): 1.34.1 [skip ci] ### [1.34.1](v1.34.0...v1.34.1) (2023-09-29) ### Bug Fixes * **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782)) * fix(deps): crossOrigin prop is not required for inputs (#386) * chore(deps): move @testing-library/react-hooks to devDependencies * fix(deps): override @types/react of react-windowed-select to ^17.0.67 * chore(deps): pin @types/react overrides --------- Co-authored-by: Artur Miglio <arturmiglio@gmail.com> * chore(release): 1.34.2 [skip ci] ### [1.34.2](v1.34.1...v1.34.2) (2023-10-05) ### Bug Fixes * **deps:** crossOrigin prop is not required for inputs ([#386](#386)) ([b9e7217](b9e7217)) * fix: enhanced breadcrumbs style (#390) * fix: enhanced breadcrumbs style * fix: linting error 0 unit --------- Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> * chore(release): 1.34.3 [skip ci] ### [1.34.3](v1.34.2...v1.34.3) (2023-10-11) ### Bug Fixes * enhanced breadcrumbs style ([#390](#390)) ([e364381](e364381)) * fix(infobanner): allow to override attrs in InfoBannerCard (#393) * chore(release): 1.34.4 [skip ci] ### [1.34.4](v1.34.3...v1.34.4) (2023-11-03) ### Bug Fixes * **infobanner:** allow to override attrs in InfoBannerCard ([#393](#393)) ([8b1457e](8b1457e)) * chore: pull request template cleanup * docs: correct changelog * docs: minor typo fixes --------- Co-authored-by: Nikolai Lopin <code@lopin.me> Co-authored-by: Leonardo <leonardo.divittorio@live.it> Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: hackbnw <420178+hackbnw@users.noreply.github.com> Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com> Co-authored-by: Jan Hamara <hamara.jan18@gmail.com> Co-authored-by: Lloyd Francis <lloydaf@gmail.com> Co-authored-by: Artur Miglio <arturmiglio@gmail.com> Co-authored-by: Nikolai Lopin <nikolai.lopin@free-now.com>

## [2.1.0](v2.0.1...v2.1.0) (2024-02-02) ### Features * add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05)) * add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354) ### Bug Fixes * **infobanner:** allow to override attrs in InfoBannerCard ([#393](#393)) ([8b1457e](8b1457e)) * enhanced breadcrumbs style ([#390](#390)) ([e364381](e364381)) * **deps:** crossOrigin prop is not required for inputs ([#386](#386)) ([b9e7217](b9e7217)) * **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782)) * add border secondary ([#355](#355)) ([75243ec](75243ec))

github-actions · 2024-02-02T12:30:38Z

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat: add breadcrumbs component

cc587d3

div-Leo requested review from nlopin, martimalek and jonotrujillo as code owners August 11, 2023 12:44

nlopin suggested changes Aug 14, 2023

View reviewed changes

src/components/Breadcrumbs/Breadcrumbs.tsx Show resolved Hide resolved

src/components/Breadcrumbs/docs/Breadcrumbs.storybook.mdx Outdated Show resolved Hide resolved

feat: add a11y properites

42556e2

div-Leo requested a review from nlopin August 17, 2023 08:12

nlopin approved these changes Aug 17, 2023

View reviewed changes

div-Leo merged commit ed82e05 into main Aug 18, 2023
10 checks passed

div-Leo deleted the Add-breadcrumbs branch August 18, 2023 12:25

github-actions bot pushed a commit that referenced this pull request Aug 18, 2023

chore(release): 1.33.0 [skip ci]

ac726a2

## [1.33.0](v1.32.2...v1.33.0) (2023-08-18) ### Features * add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05))

github-actions bot added the released label Aug 18, 2023

arturmiglio mentioned this pull request Sep 5, 2024

Actionable Breadcrumbs #324

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add breadcrumbs component #353

feat: add breadcrumbs component #353

div-Leo commented Aug 11, 2023

nlopin left a comment •

edited

Loading

div-Leo commented Aug 17, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Feb 2, 2024

feat: add breadcrumbs component #353

feat: add breadcrumbs component #353

Conversation

div-Leo commented Aug 11, 2023

nlopin left a comment • edited Loading

Choose a reason for hiding this comment

div-Leo commented Aug 17, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Feb 2, 2024

nlopin left a comment •

edited

Loading