Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ts and dependency issues #367

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Fix ts and dependency issues #367

merged 4 commits into from
Sep 19, 2023

Conversation

martimalek
Copy link
Contributor

@martimalek martimalek commented Aug 29, 2023

What:

Fixes TS issues that made the build fail and dependency conflicts that forced the install with the --legacy-peer-deps flag (except a conflict with react-tether, which will be solved separately).


Why:

To have a working build and cleaner deps.


How:

  • To fix the build
    • Import missing theme in InfoBanner.tsx
    • Add necessary casts in BoxedInput.tsx
  • To (almost) fix the deps conflicts
    • Migrate from @testing-library/react-hooks to @testing-library/react (the same APIs are now exposed from @testing-library/react so the former is not needed anymore)
    • Remove unused theme-ui package
    • Bump ts-jest from ^25.2.1 to ^26.5.6
    • Bump react-windowed-select from ^4.0.0 to ^5.1.0

Checklist:

  • Check react-tether TS issue in pipeline
  • Ready to be merged

After this PR the build issues are fixed and the only remaining dependency conflict is with react-tether, which will be removed from the project in favour of react-popper in #232

Relates to #232
Relates to #366 (will be closed together with #232)

@martimalek
Copy link
Contributor Author

I tried bumping react-tether to 3.x.x but there are some TS issues that didn't seem easy to solve, IMO we should directly tackle #232

@nlopin nlopin linked an issue Aug 30, 2023 that may be closed by this pull request
@martimalek martimalek merged commit 0197ac2 into next Sep 19, 2023
8 of 10 checks passed
@martimalek martimalek deleted the fix-ts-and-dependency-issues branch September 19, 2023 10:11
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Fix dependency conflicts and TS issues in next branch
3 participants