-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add inverted prop codemod #368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martimalek
requested review from
nlopin,
div-Leo and
jonotrujillo
as code owners
August 29, 2023 15:30
jonotrujillo
approved these changes
Aug 30, 2023
I've started improving the codemod to identify siblings that use the |
martimalek
force-pushed
the
inverted-prop-codemod
branch
from
October 31, 2023 15:32
5f47bc9
to
d1ecead
Compare
nlopin
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds a codemod that finds components using the
inverted
prop, removes it and wraps them in a component that forces them to use the inverted color scheme
Why:
To ease the adoption of Wave 2.0
How:
inverted-to-wrapper
codemodChecklist:
inverted
with theInvertedColorScheme
component, ideally we should identify components that useinverted
and are siblings and wrap them together (for performance)Breadcrumbs
andLogo
components to list of components that the codemod checksFlipTheme
toInvertedColorScheme
inverted-to-wrapper
Extra:
InvertedColorScheme
component does not yet exist, should be part of Add dark theme #356Closes #365