Disp 140/button #467
Merged
Disp 140/button #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alatielle
requested review from
jonotrujillo,
arturmiglio,
dornelasnelson and
JanHamara
as code owners
arturmiglio
approved these changes
Sep 13, 2024
| fontSize: theme.fontSizes[3], | ||
| fontWeight: theme.fontWeights.bold, | ||
| lineHeight: theme.lineHeights[3] | ||
| lineHeight: theme.lineHeights[3], | ||
| fontStretch: '50%' |
There was a problem hiding this comment.
💯 👏🏻 great that you noticed this in the designs!
alatielle
added a commit
that referenced
this pull request
Sep 19, 2024
* feat(experimental): add Chip and Text Add experimental theme and utils. * feat(experimental): add Button WIP * chore(storybook): upgrade to latest v8 * fix(raddi): fix order * feat(font): load Roboto Flex in Storybook * style(chip): remove commented/unused code * feat(button): adjust style * feat(text): add story * feat(button): add secondary * feat(storybook): re-order experimental folder * feat(chip): remove react import from story * feat(text): add kitchen sink * feat(input): add input * feat(input): export and fix story * Disp 105/css colors (#466) * feat: add experimental colors * feat(button): use color variables * feat(storybook): add experimental theme * chore: update package-lock --------- Co-authored-by: Lena Rashkovan <lena.rashkovan@free-now.com> * Disp 140/button (#467) * feat(storybook): add experimental themes for rider and driver * feat(button): add styling * feat(button): add pressed and focus states * fix(text): fix typography * feat(experimental): use rems in spaces --------- Co-authored-by: Lena Rashkovan <lena.rashkovan@free-now.com> * feat: add exports for experimental components (#464) * feat: add exports for experimental components * chore: rollback manual rc version * feat(experimental): add color palette and global styles to export * chore: put codemods back --------- Co-authored-by: Lena Rashkovan <lena.rashkovan@free-now.com> * Disp 139/input (#468) * feat(input): replace base input with react-aria component * feat(text-field): add basic styles and structure * feat(text-field): add a flying label * feat(text-field): add a flying label * feat(text-field): add clearing * chore(text-field): silence the style linter * feat(text-field): add auto grow * fix(text-field): fix overflow jump --------- Co-authored-by: Lena Rashkovan <lena.rashkovan@free-now.com> --------- Co-authored-by: Artur Miglio <artur.miglio@free-now.com> Co-authored-by: Lena Rashkovan <lena.rashkovan@free-now.com> Co-authored-by: martimalek <46452321+martimalek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Button: Added all possible button states
Typography: Added loading the variable font and supported variable font-width
Media
Button
Typography
Why
Resolves DISP-140
How